Asking for feedback: new ModbusWorker implementation

As discussed with @Sn0w3y, I’ve created a new PR with the suggested changes since his PR was automatically closed due to inactivity:

Fix Modbus task scheduling and simplify task handling by timo-schlegel · Pull Request #3547 · OpenEMS/openems

Hi,

would be nice, if you could at least add me as Contributor to the PR.

Greetings

Definitely! I wanted to add you as a contributor yesterday, but I couldn’t find a way to do it. Can you help me figure out how?

GitHub unfortunately doesn’t have a button to manually add someone as a contributor to a PR.
Contributors are determined purely by commits.

The easiest way (also works with GitHub Desktop) is to create a small commit and add this line to the commit message:

Authored-by: Sn0w3y <hallerjo97@gmail.com>

After pushing the commit, I will automatically appear as a contributor on the PR.

The contributor was added, but it was required to use ‘Co-authored-by’.

1 Like

I merged this PR just now. Thank you for your contribution and the effort!

PS: to recognize co-authors in Github I usually use this little tool: https://coauthoredby.netlify.app/