# Difficulty merging develop branch into stale branch feature/microcare-comms-bridge

**URL:** <https://community.openems.io/t/difficulty-merging-develop-branch-into-stale-branch-feature-microcare-comms-bridge/92>\
**Category:** Software-Development\
**Created:** [June 27, 2019, 1:47pm UTC](https://community.openems.io/t/difficulty-merging-develop-branch-into-stale-branch-feature-microcare-comms-bridge/92 "2019-06-27T13:47:07Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![KyleMicrocare](https://community.openems.io/user_avatar/community.openems.io/kylemicrocare/32/60_2.png) [@KyleMicrocare](https://community.openems.io/u/KyleMicrocare)\
**Post date:** [June 27, 2019, 1:47pm UTC](https://community.openems.io/t/difficulty-merging-develop-branch-into-stale-branch-feature-microcare-comms-bridge/92/1 "2019-06-27T13:47:07Z")

</div>

I was working on a feature for OpenEMS that would allow MC-Comms communication via a generic bridge. I was working on the feature/microcare-comms-bridge branch. I’ve been working on other projects for some time and have not updated this branch with upstream changes from the develop branch until recently. I’ve merged the changes as best I could, but have run into an issue where activating the MC Comms Bridge component leads to the following output: [https://paste.ubuntu.com/p/JqxwbHBghm/](https://paste.ubuntu.com/p/JqxwbHBghm/)

I suspect I’m missing something fairly obvious that should have been done during the merge.

---

<div class="post-metadata">

**Author:** ![stefan.feilmeier](https://community.openems.io/user_avatar/community.openems.io/stefan.feilmeier/32/2585_2.png) [@stefan.feilmeier](https://community.openems.io/u/stefan.feilmeier)\
**Post date:** [June 30, 2019, 5:13pm UTC](https://community.openems.io/t/difficulty-merging-develop-branch-into-stale-branch-feature-microcare-comms-bridge/92/2 "2019-06-30T17:13:31Z")

</div>

Hi Kyle,

good to have you here. The error is actually no error… I pulled your branch and the MC-Comms bridge gets actually activated properly.

The error message comes from a little service I wrote to detect Components that do not get executed - e.g. if they @Reference other Components that are not configured/enabled. This check is done in [OsgiValidateWorker](https://github.com/OpenEMS/openems/blob/develop/io.openems.edge.core/src/io/openems/edge/core/componentmanager/OsgiValidateWorker.java#L52). The problem is, that in order to check if your Component is activated, it needs to implement the _OpenemsComponent_ interface, which your MC-Comms bridge currently does not.

I added a commit to your branch, that fixes it:

> <https://github.com/OpenEMS/openems/commit/35eb4735cf7b22ee05ba20e93d927512aec27e9b>

Regards,  
Stefan

---

<div class="post-metadata">

**Author:** ![KyleMicrocare](https://community.openems.io/user_avatar/community.openems.io/kylemicrocare/32/60_2.png) [@KyleMicrocare](https://community.openems.io/u/KyleMicrocare)\
**Post date:** [July 2, 2019, 10:08am UTC](https://community.openems.io/t/difficulty-merging-develop-branch-into-stale-branch-feature-microcare-comms-bridge/92/3 "2019-07-02T10:08:36Z")

</div>

Thanks Stefan, I appreciate the fix.
