DC Chargers in ESS Modal widget

tsicking · April 18, 2024, 11:19am

Recently, we were confused when looking at the ESS modal widget in the UI (see Screenshot):

On that edge, we have two Hybrid-ESSs activated (SMA and Sungrow), and their DC chargers appear in the ESS widget, and the power values are their Actual Powers. Similarly, in the history widget the DC chargers appear. We found that confusing, as to our understanding, the DC chargers are the PV parts of a Hybrid ESS and should appear only in the production widgets (where they appear, too).
After we saw that the Chargers don’t appear in the ESS widget on another edge, we dug a bit deeper and found that the chargers only appear when more than one ESS is activated, see here:

github.com

OpenEMS/openems/blob/c78334d8810d2a291511a9fa3e1c6072c03da84a/ui/src/app/edge/live/common/storage/modal/modal.component.html#L689


      
                                      </ng-container>
                                  </ng-container>
                              </ng-container>
                          </ion-card-content>
                      </ng-container>
                  </ng-container>
              </ng-container>
          </ng-container>
          
          <!-- DC Charger -->
          <ng-container *ngIf="chargerComponents?.length !== 0 && essComponents?.length !== 1">
              <ng-container *ngFor="let component of chargerComponents">
                  <ion-card-content [class.underline]="!isLastElement(component, chargerComponents)">
                      <table *ngIf="(edge.currentData | async)['channel'] as currentData" class="full_width">
                          <ng-container *ngVar="currentData[component.id + '/ActualPower'] as value">
                              <ng-container *ngIf="value !== null && value !== undefined">
                                  <tr>
                                      <td style="width: 100%">{{ component.alias }}</td>
                                  </tr>
                                  <tr>
                                      <td style="width:20%" translate>General.chargePower</td>

We are now wondering why
a) the chargers appear in the ESS widget at all and
b) they only appear when there is more than one ESS activated.

Does anyone have any explanation fot r this?

Best regards,
Thomas

stefan.feilmeier · April 21, 2024, 8:35pm

Thanks Thomas. No, there is no specific reason for this behaviour. It’s just what happens when creating 1000-lines long untested logic in HTML…

The file is on the list to be refactored similarly to the Consumption Modal, by extending an AbstractFormlyComponent → openems/ui/src/app/edge/live/common/consumption/modal/modal.ts at develop · OpenEMS/openems · GitHub

(@lukasrgr FYI)

Regards,
Stefan